Add support for exclude markers. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/exclude_markers
branch
from
15c8892 to
e673af6
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
+ Coverage 94.81% 96.41% +1.6%
=========================================
Files 4 4
Lines 212 223 +11
=========================================
+ Hits 201 215 +14
+ Misses 11 8 -3
Continue to review full report at Codecov.
|
maleadt
force-pushed
the
tb/exclude_markers
branch
from
e673af6 to
13bc1dd
Compare
|
Not sure why 1.0 yields completely different coverage results here; the other tests behave like that... |
vtjnash
reviewed
Jan 21, 2020
vtjnash
approved these changes
Jan 21, 2020
maleadt
force-pushed
the
tb/exclude_markers
branch
from
f5b9839 to
5ee56e3
Compare
Fixes #34.
maleadt
force-pushed
the
tb/exclude_markers
branch
from
5ee56e3 to
3784ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for three simple source markers that remove coverage:
COV_EXCL_LINEto exclude a single line, andCOV_EXCL_STARTtoCOV_EXCL_STOPto define respectively the start and end of a section of code that should be excluded. These mimic (and are compatible with) similar markers as found in lcov and gcov: http://ltp.sourceforge.net/coverage/lcov/geninfo.1.phpThe changes are based on JuliaCI/Coverage.jl#218, but I left out support for excluding files (and the ability to configure using a
.coverage.yml) because that is covered by existing tools already: Codecov.io supports anignorelist in its.codecov.yml, and LCOV tracefiles can be pruned withlcov --remove. We can always add that functionality later on, but this seems like a straightforward first step.